From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:54:56
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/micrel/ksz884x.c:2163: warning: expecting prototype for sw_get_board_storm(). Prototype was for sw_get_broad_storm() instead
drivers/net/ethernet/micrel/ksz884x.c:2985: warning: expecting prototype for port_w_phy(). Prototype was for hw_w_phy() instead
drivers/net/ethernet/micrel/ksz884x.c:4792: warning: expecting prototype for transmit_done(). Prototype was for tx_done() instead
Cc: Tristram Ha <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/micrel/ksz884x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:55:16
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/calxeda/xgmac.c:720: warning: expecting prototype for init_xgmac_dma_desc_rings(). Prototype was for xgmac_dma_desc_rings_init() instead
drivers/net/ethernet/calxeda/xgmac.c:867: warning: expecting prototype for xgmac_tx(). Prototype was for xgmac_tx_complete() instead
drivers/net/ethernet/calxeda/xgmac.c:1049: warning: expecting prototype for xgmac_release(). Prototype was for xgmac_stop() instead
drivers/net/ethernet/calxeda/xgmac.c:1822: warning: expecting prototype for xgmac_dvr_remove(). Prototype was for xgmac_remove() instead
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v, int a, int u)}/**-*atomic_dec_ifmoe-deciftheresultismoreorequalthanagivenvalue.+*__atomic_dec_ifmoe-deciftheresultismoreorequalthanagivenvalue.**@v:pointeroftypeatomic_t*@a:theamounttodecfromv...
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:55:58
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:367: warning: expecting prototype for atl1e_set_mac(). Prototype was for atl1e_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:796: warning: expecting prototype for atl1e_setup_mem_resources(). Prototype was for atl1e_setup_ring_resources() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:56:10
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:442: warning: expecting prototype for atl1c_set_mac(). Prototype was for atl1c_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:969: warning: expecting prototype for atl1c_setup_mem_resources(). Prototype was for atl1c_setup_ring_resources() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1375: warning: expecting prototype for atl1c_configure(). Prototype was for atl1c_configure_mac() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:56:18
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:604: warning: expecting prototype for cmdq_arm_ceq_handler(). Prototype was for cmdq_sync_cmd_handler() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:59: warning: expecting prototype for get_capability(). Prototype was for parse_capability() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:101: warning: expecting prototype for get_cap_from_fw(). Prototype was for get_capability() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:355: warning: expecting prototype for clear_io_resource(). Prototype was for clear_io_resources() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:1100: warning: expecting prototype for hinic_hwdev_get_sq(). Prototype was for hinic_hwdev_get_rq() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_if.c:341: warning: expecting prototype for dma_attr_table_init(). Prototype was for dma_attr_init() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c:904: warning: expecting prototype for hinic_put_wqe(). Prototype was for hinic_rq_put_wqe() instead
drivers/net/ethernet/huawei/hinic/hinic_main.c:241: warning: expecting prototype for create_txqs(). Prototype was for create_rxqs() instead
drivers/net/ethernet/huawei/hinic/hinic_main.c:295: warning: expecting prototype for free_txqs(). Prototype was for free_rxqs() instead
drivers/net/ethernet/huawei/hinic/hinic_tx.c:667: warning: expecting prototype for free_all_rx_skbs(). Prototype was for free_all_tx_skbs() instead
Cc: Bin Luo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 8 ++++----
drivers/net/ethernet/huawei/hinic/hinic_hw_if.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_main.c | 4 ++--
drivers/net/ethernet/huawei/hinic/hinic_tx.c | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:56:55
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/hw.c:119: warning: expecting prototype for ath_hw_set_bssid_mask(). Prototype was for ath_hw_setbssidmask() instead
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:19
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:797: warning: expecting prototype for sxgbe_tx_clean(). Prototype was for sxgbe_tx_all_clean() instead
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1026: warning: expecting prototype for sxgbe_init_tx_coalesce(). Prototype was for sxgbe_tx_init_coalesce() instead
Cc: Byungho An <bh74.an@samsung.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:25
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/via/via-velocity.c:1908: warning: expecting prototype for tx_srv(). Prototype was for velocity_tx_srv() instead
drivers/net/ethernet/via/via-velocity.c:2466: warning: expecting prototype for velocity_get_status(). Prototype was for velocity_get_stats() instead
drivers/net/ethernet/via/via-velocity.c:3734: warning: expecting prototype for velocity_cleanup(). Prototype was for velocity_cleanup_module() instead
Cc: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/via/via-velocity.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:38
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:11: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:45
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/neterion/vxge/vxge-config.c:4895: warning: expecting prototype for vxge_hw_vpath_rx_doorbell_post(). Prototype was for vxge_hw_vpath_rx_doorbell_init() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:1814: warning: expecting prototype for vxge_poll(). Prototype was for vxge_poll_msix() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:4761: warning: expecting prototype for vxge_rem_nic(). Prototype was for vxge_remove() instead
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:52
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/ipw2x00/ipw2100.c:5359: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/ipw2x00/ipw2100.c:6533: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/ipw2x00/ipw2100.c:6565: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:57:55
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/marvell/libertas_tf/if_usb.c:56: warning: expecting prototype for if_usb_wrike_bulk_callback(). Prototype was for if_usb_write_bulk_callback() instead
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:58:04
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wlcore/cmd.c:824: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wlcore/cmd.c:853: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wlcore/cmd.c:882: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ti/wlcore/cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:58:12
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wl1251/cmd.c:15: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:103: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:141: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ti/wl1251/cmd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:58:16
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/neterion/s2io.c:2759: warning: expecting prototype for s2io_poll(). Prototype was for s2io_poll_msix() instead
drivers/net/ethernet/neterion/s2io.c:5304: warning: expecting prototype for s2io_ethtol_get_link_ksettings(). Prototype was for s2io_ethtool_get_link_ksettings() instead
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/neterion/s2io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:58:22
Fixes the following W=1 kernel build warning(s):
drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/phy/adin.c | 2 +-
drivers/net/phy/rockchip.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:58:53
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting prototype for at5k_hw_stop_rx_pcu(). Prototype was for ath5k_hw_stop_rx_pcu() instead
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Kalle Valo <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-15 10:59:09
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/wil6210/interrupt.c:28: warning: expecting prototype for Theory of operation(). Prototype was for WIL6210_IRQ_DISABLE() instead
drivers/net/wireless/ath/wil6210/wmi.c:227: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ath/wil6210/wmi.c:245: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ath/wil6210/wmi.c:263: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Maya Erez <redacted>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/wil6210/interrupt.c | 2 +-
drivers/net/wireless/ath/wil6210/wmi.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
Am Samstag, 15. Mai 2021, 12:53:26 CEST schrieb Yang Shen:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/arc/emac_rockchip.c:18: warning: expecting prototype for emac(). Prototype was for DRV_NAME() instead
Cc: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Ok, if it raises a warning.
But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
with same change to a combined patch.
Regards,
Nicolas
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-15 14:20:09
On Sat, May 15, 2021 at 06:53:48PM +0800, Yang Shen wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-15 14:24:17
On Sat, May 15, 2021 at 06:53:27PM +0800, Yang Shen wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:442: warning: expecting prototype for atl1c_set_mac(). Prototype was for atl1c_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:969: warning: expecting prototype for atl1c_setup_mem_resources(). Prototype was for atl1c_setup_ring_resources() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1375: warning: expecting prototype for atl1c_configure(). Prototype was for atl1c_configure_mac() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-15 14:24:17
On Sat, May 15, 2021 at 06:53:28PM +0800, Yang Shen wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:367: warning: expecting prototype for atl1e_set_mac(). Prototype was for atl1e_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:796: warning: expecting prototype for atl1e_setup_mem_resources(). Prototype was for atl1e_setup_ring_resources() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-15 14:25:45
On Sat, May 15, 2021 at 06:53:29PM +0800, Yang Shen wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atlx/atl1.c:1020: warning: expecting prototype for atl1_setup_mem_resources(). Prototype was for atl1_setup_ring_resources() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
From: Yang Shen <shenyang39@huawei.com> Date: 2021-05-17 01:48:51
On 2021/5/15 20:46, Nicolas.Ferre@microchip.com wrote:
On 15/05/2021 at 12:53, Yang Shen wrote:
quoted
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Ok, if it raises a warning.
But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
with same change to a combined patch.
Regards,
Nicolas
OK，The compiler missed this warning at
drivers/net/ethernet/cadence/macb_pci.c.
I'll fix this in the next version.
Thanks,
Yang
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/socionext/sni_ave.c:28: warning: expecting prototype for sni_ave.c(). Prototype was for AVE_IDR() instead
Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
I confirmed the fix of the warning.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
From: Simon Horman <hidden> Date: 2021-05-17 09:45:18
On Sat, May 15, 2021 at 06:53:42PM +0800, Yang Shen wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead
Cc: Simon Horman <redacted>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Thanks,
looks good to me.
Signed-off-by: Simon Horman <redacted>