[PATCH v3 0/2] remove different PHY fixups - dts part

STALE1905d

6 messages, 3 authors, 2021-05-23 · open the first message on its own page

[PATCH v3 0/2] remove different PHY fixups - dts part

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-05-11 04:31:08

changes v3:
- split arch and dts changes

changes v2:
- rebase against latest kernel
- fix networking on RIoTBoard

This patch series tries to remove most of the imx6 and imx7 board
specific PHY configuration via fixup, as this breaks the PHYs when
connected to switch chips or USB Ethernet MACs.

Each patch has the possibility to break boards, but contains a
recommendation to fix the problem in a more portable and future-proof
way.

Oleksij Rempel (2):
  ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
  ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE
    value

 arch/arm/boot/dts/imx6dl-riotboard.dts  | 2 ++
 arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.29.2

[PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-05-11 04:30:56

Latest kernel is actually using phy-mode property, so set proper value to make
fec interface work again.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index fa2307d8ce86..c713ac03b3b9 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -112,7 +112,7 @@ flash: m25p80@0 {
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	phy-supply = <&vgen2_1v2_eth>;
 	status = "okay";
-- 
2.29.2

[PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-05-11 04:31:01

Without SoC specific PHY fixups the network interface on this board will
fail to work. Provide missing DT properties to make it work again.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/imx6dl-riotboard.dts | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 065d3ab0f50a..e7d9bfbfd0e4 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -106,6 +106,8 @@ rgmii_phy: ethernet-phy@4 {
 			reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
 			reset-deassert-us = <1000>;
+			qca,smarteee-tw-us-1g = <24>;
+			qca,clk-out-frequency = <125000000>;
 		};
 	};
 };
-- 
2.29.2

Re: [PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-05-11 12:48:29

On Tue, May 11, 2021 at 06:30:38AM +0200, Oleksij Rempel wrote:
Latest kernel is actually using phy-mode property, so set proper value to make
fec interface work again.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-05-11 12:49:03

On Tue, May 11, 2021 at 06:30:39AM +0200, Oleksij Rempel wrote:
Without SoC specific PHY fixups the network interface on this board will
fail to work. Provide missing DT properties to make it work again.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH v3 0/2] remove different PHY fixups - dts part

From: Shawn Guo <shawnguo@kernel.org>
Date: 2021-05-23 03:29:25

On Tue, May 11, 2021 at 06:30:37AM +0200, Oleksij Rempel wrote:
changes v3:
- split arch and dts changes

changes v2:
- rebase against latest kernel
- fix networking on RIoTBoard

This patch series tries to remove most of the imx6 and imx7 board
specific PHY configuration via fixup, as this breaks the PHYs when
connected to switch chips or USB Ethernet MACs.

Each patch has the possibility to break boards, but contains a
recommendation to fix the problem in a more portable and future-proof
way.

Oleksij Rempel (2):
  ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
  ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE
    value
Applied both, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help