[PATCH net] sctp: fix the proc_handler for sysctl encap_port

Subsystems: networking [general], sctp protocol, the rest

STALE1897d

2 messages, 2 authors, 2021-05-25 · open the first message on its own page

[PATCH net] sctp: fix the proc_handler for sysctl encap_port

From: Xin Long <lucien.xin@gmail.com>
Date: 2021-05-25 02:49:46

proc_dointvec() cannot do min and max check for setting a value
when extra1/extra2 is set, so change it to proc_dointvec_minmax()
for sysctl encap_port.

Fixes: e8a3001c2120 ("sctp: add encap_port for netns sock asoc and transport")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 net/sctp/sysctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index e92df779af73..55871b277f47 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -307,7 +307,7 @@ static struct ctl_table sctp_net_table[] = {
 		.data		= &init_net.sctp.encap_port,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dointvec_minmax,
 		.extra1		= SYSCTL_ZERO,
 		.extra2		= &udp_port_max,
 	},
-- 
2.27.0

Re: [PATCH net] sctp: fix the proc_handler for sysctl encap_port

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-05-25 22:20:14

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 24 May 2021 22:49:42 -0400 you wrote:
proc_dointvec() cannot do min and max check for setting a value
when extra1/extra2 is set, so change it to proc_dointvec_minmax()
for sysctl encap_port.

Fixes: e8a3001c2120 ("sctp: add encap_port for netns sock asoc and transport")
Signed-off-by: Xin Long <lucien.xin@gmail.com>

[...]
Here is the summary with links:
  - [net] sctp: fix the proc_handler for sysctl encap_port
    https://git.kernel.org/netdev/net/c/b2540cdce6e2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help