[PATCH net-next] net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()

Subsystems: arm/intel ixp4xx arm architecture, networking drivers, the rest

STALE1946d

2 messages, 2 authors, 2021-05-19 · open the first message on its own page

[PATCH net-next] net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()

From: Wei Yongjun <hidden>
Date: 2021-05-19 14:07:15

In case of error, the function mdiobus_get_phy() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/xscale/ixp4xx_eth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index cb89323855d8..1ecceeb9700d 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1531,8 +1531,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
 		phydev = of_phy_get_and_connect(ndev, np, ixp4xx_adjust_link);
 	} else {
 		phydev = mdiobus_get_phy(mdio_bus, plat->phy);
-		if (IS_ERR(phydev)) {
-			err = PTR_ERR(phydev);
+		if (!phydev) {
+			err = -ENODEV;
 			dev_err(dev, "could not connect phydev (%d)\n", err);
 			goto err_free_mem;
 		}

Re: [PATCH net-next] net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-05-19 20:20:19

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 19 May 2021 14:16:27 +0000 you wrote:
In case of error, the function mdiobus_get_phy() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>

[...]
Here is the summary with links:
  - [net-next] net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()
    https://git.kernel.org/netdev/net-next/c/20e76d3d044d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help