# Re: \[PATCH net\] netns: export get\_net\_ns\_by\_id()

- From: Nicolas Dichtel \<hidden\>
- Date: 2021-05-17 07:18:40 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/05/11203287
- Thread: https://ratatoskr.run/netdev/2021/05/11203140/t.md

```text
Le 16/05/2021 à 13:05, Leon Romanovsky a écrit :
> On Fri, May 14, 2021 at 11:52:51PM +0300, Sergey Ryazanov wrote:
>> On Fri, May 14, 2021 at 10:14 PM Jakub Kicinski [ref] wrote:
>>> On Thu, 13 May 2021 00:29:56 +0300 Sergey Ryazanov wrote:
>>>> No one loadable module is able to obtain netns by id since the
>>>> corresponding function has not been exported. Export it to be able to
>>>> use netns id API in loadable modules too as already done for
>>>> peernet2id_alloc().
>>>
>>> peernet2id_alloc() is used by OvS, what's the user for get_net_ns_by_id()?
>>
>> There are currently no active users of get_net_ns_by_id(), that is why
>> I did not add a "Fix" tag. Missed function export does not break
>> existing code in any way.
> 
> It is against kernel rule to do not expose APIs, even internal to the kernel,
Yep, there was no internal user, it's why I didn't add this EXPORT_*() at the
beginning.


Regards,
Nicolas
```