# Re: \[PATCH 11/18\] iommu/fsl\_pamu: remove the snoop\_id field

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-04-01 09:37:36 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/04/8286235
- Thread: https://ratatoskr.run/linuxppc-dev/2021/03/8286060/t.md

```text
On Tue, Mar 30, 2021 at 01:58:17PM +0100, Will Deacon wrote:
> pamu_config_ppaace() takes quite a few useless parameters at this stage,
> but anyway:

I'll see it it makes sense to throw in another patch at the end to cut
it down a bit more.

> Acked-by: Will Deacon <will@kernel.org>
> 
> Do you know if this driver is actually useful? Once the complexity has been
> stripped back, the stubs and default values really stand out.

Yeah.  No idea what the usefulness of this driver is.  Bascially all it
seems to do is to setup a few registers to allow access to the whole
physical memory.  But maybe that is required on this hardware to allow
for any DMA access?
```
