[PATCH] wireless: Simplify expression

Subsystems: networking drivers (wireless), the rest

STALE1913d LANDED

Landed in mainline as ad4d74cd8177 on 2021-06-15.

2 messages, 2 authors, 2021-06-15 · open the first message on its own page

[PATCH] wireless: Simplify expression

From: <hidden>
Date: 2021-04-23 09:50:03

From: zuoqilin <redacted>

It is not necessary to define the variable ret to receive
the return value of the get_bssid() method.

Signed-off-by: zuoqilin <redacted>
---
 drivers/net/wireless/rndis_wlan.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 9fe7755..63ce244 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1036,14 +1036,11 @@ static bool is_associated(struct usbnet *usbdev)
 {
 	struct rndis_wlan_private *priv = get_rndis_wlan_priv(usbdev);
 	u8 bssid[ETH_ALEN];
-	int ret;
 
 	if (!priv->radio_on)
 		return false;
 
-	ret = get_bssid(usbdev, bssid);
-
-	return (ret == 0 && !is_zero_ether_addr(bssid));
+	return (get_bssid(usbdev, bssid) == 0 && !is_zero_ether_addr(bssid));
 }
 
 static int disassociate(struct usbnet *usbdev, bool reset_ssid)
-- 
1.9.1

Re: rndis_wlan: simplify is_associated()

From: Kalle Valo <hidden>
Date: 2021-06-15 13:35:15

zuoqilin1@163.com wrote:
From: zuoqilin <redacted>

It is not necessary to define the variable ret to receive
the return value of the get_bssid() method.

Signed-off-by: zuoqilin <redacted>
Patch applied to wireless-drivers-next.git, thanks.

ad4d74cd8177 rndis_wlan: simplify is_associated()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210423094940.1593-1-zuoqilin1@163.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help