[PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

Subsystems: realtek wireless driver (rtlwifi family), the rest

STALE1976d LANDED

Landed in mainline as e9642be26a37 on 2021-04-17.

2 messages, 2 authors, 2021-04-17 · open the first message on its own page

[PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

From: Huang Guobin <hidden>
Date: 2021-04-06 12:17:12

From: Guobin Huang <redacted>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>
---
 .../realtek/rtlwifi/rtl8192de/sw.c         | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
index 1dbdddce0823..a74724c971b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
@@ -372,18 +372,14 @@ static struct pci_driver rtl92de_driver = {
 
 /* add global spin lock to solve the problem that
  * Dul mac register operation on the same time */
-spinlock_t globalmutex_power;
-spinlock_t globalmutex_for_fwdownload;
-spinlock_t globalmutex_for_power_and_efuse;
+DEFINE_SPINLOCK(globalmutex_power);
+DEFINE_SPINLOCK(globalmutex_for_fwdownload);
+DEFINE_SPINLOCK(globalmutex_for_power_and_efuse);
 
 static int __init rtl92de_module_init(void)
 {
 	int ret = 0;
 
-	spin_lock_init(&globalmutex_power);
-	spin_lock_init(&globalmutex_for_fwdownload);
-	spin_lock_init(&globalmutex_for_power_and_efuse);
-
 	ret = pci_register_driver(&rtl92de_driver);
 	if (ret)
 		WARN_ONCE(true, "rtl8192de: No device found\n");

Re: [PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

From: Kalle Valo <hidden>
Date: 2021-04-17 17:34:44

Huang Guobin [off-list ref] wrote:
From: Guobin Huang <redacted>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>
Patch applied to wireless-drivers-next.git, thanks.

e9642be26a37 rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1617711406-49649-1-git-send-email-huangguobin4@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help