[PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI

Subsystems: networking drivers, smsc911x ethernet driver, the rest

STALE1989d

2 messages, 2 authors, 2021-04-05 · open the first message on its own page

[PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI

From: Krzysztof Kozlowski <hidden>
Date: 2021-04-05 18:15:58

The driver can match via multiple methods.  Its acpi_device_id table is
referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds:

  drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning:
    ‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/net/ethernet/smsc/smsc911x.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 606c79de93a6..556a9790cdcf 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2649,11 +2649,13 @@ static const struct of_device_id smsc911x_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, smsc911x_dt_ids);
 #endif
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id smsc911x_acpi_match[] = {
 	{ "ARMH9118", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match);
+#endif
 
 static struct platform_driver smsc911x_driver = {
 	.probe = smsc911x_drv_probe,
-- 
2.25.1

Re: [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-04-05 22:10:37

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon,  5 Apr 2021 20:15:48 +0200 you wrote:
The driver can match via multiple methods.  Its acpi_device_id table is
referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds:

  drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning:
    ‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <redacted>

[...]
Here is the summary with links:
  - net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI
    https://git.kernel.org/netdev/net-next/c/cc0626c2aaed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help