# Re: \[PATCH net v2 0/3\] Action initalization fixes

- From: Cong Wang \<hidden\>
- Date: 2021-04-08 22:02:25 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/04/11201076
- Thread: https://ratatoskr.run/netdev/2021/04/11200898/t.md

```text
On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov [ref] wrote:
>
> This series fixes reference counting of action instances and modules in
> several parts of action init code. The first patch reverts previous fix
> that didn't properly account for rollback from a failure in the middle of
> the loop in tcf_action_init() which is properly fixed by the following
> patch.

I still hate the init_res[] array, but I have no easy and better way to fix
it either, so:

Acked-by: Cong Wang <redacted>

For the long term, we probably want to split the action ->init() into
two: ->init() and ->change(), like TC filters, which hopefully could
ease the complexity of tcf_action_init_1().

Thanks.
```