[PATCH bpf-next] tools/resolve_btfids: Fix warnings

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE1963d

2 messages, 1 author, 2021-03-29 · open the first message on its own page

[PATCH bpf-next] tools/resolve_btfids: Fix warnings

From: Stanislav Fomichev <hidden>
Date: 2021-03-29 16:25:03

* make eprintf static, used only in main.c
* initialize ret in eprintf
* remove unused *tmp

Signed-off-by: Stanislav Fomichev <redacted>
---
 tools/bpf/resolve_btfids/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 80d966cfcaa1..a650422f7430 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -115,10 +115,10 @@ struct object {
 
 static int verbose;
 
-int eprintf(int level, int var, const char *fmt, ...)
+static int eprintf(int level, int var, const char *fmt, ...)
 {
 	va_list args;
-	int ret;
+	int ret = 0;
 
 	if (var >= level) {
 		va_start(args, fmt);
@@ -403,7 +403,7 @@ static int symbols_collect(struct object *obj)
 	 * __BTF_ID__* over .BTF_ids section.
 	 */
 	for (i = 0; !err && i < n; i++) {
-		char *tmp, *prefix;
+		char *prefix;
 		struct btf_id *id;
 		GElf_Sym sym;
 		int err = -1;
-- 
2.31.0.291.g576ba9dcdaf-goog

Re: [PATCH bpf-next] tools/resolve_btfids: Fix warnings

From: <hidden>
Date: 2021-03-29 16:40:41

On 03/29, Stanislav Fomichev wrote:
* make eprintf static, used only in main.c
* initialize ret in eprintf
* remove unused *tmp
Signed-off-by: Stanislav Fomichev <redacted>
---
  tools/bpf/resolve_btfids/main.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
quoted hunk
diff --git a/tools/bpf/resolve_btfids/main.c  
b/tools/bpf/resolve_btfids/main.c
index 80d966cfcaa1..a650422f7430 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -115,10 +115,10 @@ struct object {
  static int verbose;
-int eprintf(int level, int var, const char *fmt, ...)
+static int eprintf(int level, int var, const char *fmt, ...)
  {
  	va_list args;
-	int ret;
+	int ret = 0;
quoted hunk
  	if (var >= level) {
  		va_start(args, fmt);
@@ -403,7 +403,7 @@ static int symbols_collect(struct object *obj)
  	 * __BTF_ID__* over .BTF_ids section.
  	 */
  	for (i = 0; !err && i < n; i++) {
-		char *tmp, *prefix;
+		char *prefix;
  		struct btf_id *id;
  		GElf_Sym sym;
  		int err = -1;
--
2.31.0.291.g576ba9dcdaf-goog

Looks like that 'int err = -1' is also unused.
I'll respin, please ignore this one. Sorry for the noise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help