[Patch bpf-next] skmsg: add function doc for skb->_sk_redir

Subsystems: networking [general], the rest

STALE2015d LANDED

Landed in mainline as 6ed6e1c761f6 on 2021-03-04.

4 messages, 4 authors, 2021-03-04 · open the first message on its own page

[Patch bpf-next] skmsg: add function doc for skb->_sk_redir

From: Cong Wang <hidden>
Date: 2021-03-01 18:51:46

From: Cong Wang <redacted>

This should fix the following warning:

include/linux/skbuff.h:932: warning: Function parameter or member
'_sk_redir' not described in 'sk_buff'

Reported-by: Lorenz Bauer <redacted>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Cong Wang <redacted>
---
 include/linux/skbuff.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index bd84f799c952..0503c917d773 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -656,6 +656,7 @@ typedef unsigned char *sk_buff_data_t;
  *	@protocol: Packet protocol from driver
  *	@destructor: Destruct function
  *	@tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
+ *	@_sk_redir: socket redirection information for skmsg
  *	@_nfct: Associated connection, if any (with nfctinfo bits)
  *	@nf_bridge: Saved data about a bridged frame - see br_netfilter.c
  *	@skb_iif: ifindex of device we arrived on
-- 
2.25.1

RE: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

From: John Fastabend <john.fastabend@gmail.com>
Date: 2021-03-01 18:58:52

Cong Wang wrote:
quoted hunk
From: Cong Wang <redacted>

This should fix the following warning:

include/linux/skbuff.h:932: warning: Function parameter or member
'_sk_redir' not described in 'sk_buff'

Reported-by: Lorenz Bauer <redacted>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Cong Wang <redacted>
---
 include/linux/skbuff.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index bd84f799c952..0503c917d773 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -656,6 +656,7 @@ typedef unsigned char *sk_buff_data_t;
  *	@protocol: Packet protocol from driver
  *	@destructor: Destruct function
  *	@tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
+ *	@_sk_redir: socket redirection information for skmsg
  *	@_nfct: Associated connection, if any (with nfctinfo bits)
  *	@nf_bridge: Saved data about a bridged frame - see br_netfilter.c
  *	@skb_iif: ifindex of device we arrived on
-- 
2.25.1
Acked-by: John Fastabend <john.fastabend@gmail.com>

Re: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

From: Lorenz Bauer <hidden>
Date: 2021-03-02 10:39:13

On Mon, 1 Mar 2021 at 18:48, Cong Wang [off-list ref] wrote:
From: Cong Wang <redacted>

This should fix the following warning:

include/linux/skbuff.h:932: warning: Function parameter or member
'_sk_redir' not described in 'sk_buff'
Thanks!

Acked-by: Lorenz Bauer <redacted>

-- 
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com

Re: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-04 15:41:55

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon,  1 Mar 2021 10:48:05 -0800 you wrote:
From: Cong Wang <redacted>

This should fix the following warning:

include/linux/skbuff.h:932: warning: Function parameter or member
'_sk_redir' not described in 'sk_buff'

[...]
Here is the summary with links:
  - [bpf-next] skmsg: add function doc for skb->_sk_redir
    https://git.kernel.org/bpf/bpf-next/c/6ed6e1c761f6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help