[PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

Subsystems: networking drivers, ppp protocol drivers and compressors, the rest

STALE1952d

2 messages, 2 authors, 2021-03-31 · open the first message on its own page

[PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

From: Jiapeng Chong <hidden>
Date: 2021-03-30 09:52:25

Fix the following whitescan warning:

Calling "zlib_inflateEnd(&state->strm)" is only useful for its return
value, which is ignored.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ppp/ppp_deflate.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ppp/ppp_deflate.c b/drivers/net/ppp/ppp_deflate.c
index c457f84..e6d48e5 100644
--- a/drivers/net/ppp/ppp_deflate.c
+++ b/drivers/net/ppp/ppp_deflate.c
@@ -279,7 +279,6 @@ static void z_decomp_free(void *arg)
 	struct ppp_deflate_state *state = (struct ppp_deflate_state *) arg;
 
 	if (state) {
-		zlib_inflateEnd(&state->strm);
 		vfree(state->strm.workspace);
 		kfree(state);
 	}
-- 
1.8.3.1

Re: [PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-31 00:11:10

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 30 Mar 2021 17:51:30 +0800 you wrote:
Fix the following whitescan warning:

Calling "zlib_inflateEnd(&state->strm)" is only useful for its return
value, which is ignored.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>

[...]
Here is the summary with links:
  - ppp: deflate: Remove useless call "zlib_inflateEnd"
    https://git.kernel.org/netdev/net-next/c/dc5fa2073f63

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help