[PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

Subsystems: networking drivers, qualcomm ethqos ethernet driver, stmmac ethernet driver, the rest

STALE1956d

2 messages, 2 authors, 2021-03-29 · open the first message on its own page

[PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

From: Huang Guobin <hidden>
Date: 2021-03-29 01:51:04

From: Guobin Huang <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>
---
 .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c  | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index bfc4a92f1d92..a674b7d6b49a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -477,7 +477,6 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rgmii");
 	ethqos->rgmii_base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(ethqos->rgmii_base)) {
-		dev_err(&pdev->dev, "Can't get rgmii base\n");
 		ret = PTR_ERR(ethqos->rgmii_base);
 		goto err_mem;
 	}

Re: [PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-29 20:21:18

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 29 Mar 2021 09:49:32 +0800 you wrote:
From: Guobin Huang <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>

[...]
Here is the summary with links:
  - [net-next,v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()
    https://git.kernel.org/netdev/net-next/c/3d0dbd546345

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help