[PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

Subsystems: hirschmann hellcreek ethernet switch driver, networking drivers, networking [dsa], the rest

STALE1954d

2 messages, 2 authors, 2021-03-29 · open the first message on its own page

[PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

From: Huang Guobin <hidden>
Date: 2021-03-27 10:07:45

From: Guobin Huang <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>
---
 drivers/net/dsa/hirschmann/hellcreek.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index 918be7eb626f..4d78219da253 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1842,10 +1842,8 @@ static int hellcreek_probe(struct platform_device *pdev)
 	}
 
 	hellcreek->base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hellcreek->base)) {
-		dev_err(dev, "No memory available!\n");
+	if (IS_ERR(hellcreek->base))
 		return PTR_ERR(hellcreek->base);
-	}
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ptp");
 	if (!res) {
@@ -1854,10 +1852,8 @@ static int hellcreek_probe(struct platform_device *pdev)
 	}
 
 	hellcreek->ptp_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hellcreek->ptp_base)) {
-		dev_err(dev, "No memory available!\n");
+	if (IS_ERR(hellcreek->ptp_base))
 		return PTR_ERR(hellcreek->ptp_base);
-	}
 
 	ret = hellcreek_detect(hellcreek);
 	if (ret) {

Re: [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-29 01:11:04

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 18:07:18 +0800 you wrote:
From: Guobin Huang <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Guobin Huang <redacted>

[...]
Here is the summary with links:
  - [net-next,v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
    https://git.kernel.org/netdev/net-next/c/656151aaa623

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help