[PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block

Subsystems: bpf [core], bpf [general] (safe dynamic programs and tools), the rest

STALE1976d LANDED

Landed in mainline as 9ef05281e5d0 on 2021-03-19.

2 messages, 2 authors, 2021-03-19 · open the first message on its own page

[PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block

From: Jianlin Lv <hidden>
Date: 2021-03-18 02:50:12

Two insn_buf[16] variables are declared in the function, which act on
function scope and block scope respectively.
The statement in the inner blocks is redundant, so remove it.

Signed-off-by: Jianlin Lv <redacted>
---
 kernel/bpf/verifier.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index f9096b049cd6..e26c5170c953 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -11899,7 +11899,6 @@ static int do_misc_fixups(struct bpf_verifier_env *env)
 		    insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) {
 			const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X;
 			const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X;
-			struct bpf_insn insn_buf[16];
 			struct bpf_insn *patch = &insn_buf[0];
 			bool issrc, isneg;
 			u32 off_reg;
-- 
2.25.1

Re: [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-19 22:11:10

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 18 Mar 2021 10:48:51 +0800 you wrote:
Two insn_buf[16] variables are declared in the function, which act on
function scope and block scope respectively.
The statement in the inner blocks is redundant, so remove it.

Signed-off-by: Jianlin Lv <redacted>
---
 kernel/bpf/verifier.c | 1 -
 1 file changed, 1 deletion(-)
Here is the summary with links:
  - [bpf-next] bpf: Remove insn_buf[] declaration in inner block
    https://git.kernel.org/bpf/bpf-next/c/9ef05281e5d0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help