[PATCH v2] ethernet/broadcom:remove unneeded variable: "ret"

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE2024d

2 messages, 2 authors, 2021-03-17 · open the first message on its own page

[PATCH v2] ethernet/broadcom:remove unneeded variable: "ret"

From: <hidden>
Date: 2021-03-17 12:30:58

From: dingsenjie <redacted>

remove unneeded variable: "ret".

Signed-off-by: dingsenjie <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 28069b2..f30193f 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -1395,7 +1395,6 @@ int bnx2x_send_final_clnup(struct bnx2x *bp, u8 clnup_func, u32 poll_cnt)
 	u32 op_gen_command = 0;
 	u32 comp_addr = BAR_CSTRORM_INTMEM +
 			CSTORM_FINAL_CLEANUP_COMPLETE_OFFSET(clnup_func);
-	int ret = 0;
 
 	if (REG_RD(bp, comp_addr)) {
 		BNX2X_ERR("Cleanup complete was not 0 before sending\n");
@@ -1420,7 +1419,7 @@ int bnx2x_send_final_clnup(struct bnx2x *bp, u8 clnup_func, u32 poll_cnt)
 	/* Zero completion for next FLR */
 	REG_WR(bp, comp_addr, 0);
 
-	return ret;
+	return 0;
 }
 
 u8 bnx2x_is_pcie_pending(struct pci_dev *dev)
-- 
1.9.1

Re: [PATCH v2] ethernet/broadcom:remove unneeded variable: "ret"

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-17 21:51:21

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 17 Mar 2021 20:29:33 +0800 you wrote:
From: dingsenjie <redacted>

remove unneeded variable: "ret".

Signed-off-by: dingsenjie <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
  - [v2] ethernet/broadcom:remove unneeded variable: "ret"
    https://git.kernel.org/netdev/net-next/c/f0744a84f361

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help