[PATCH net-next] net: ipa: make ipa_table_hash_support() inline

Subsystems: networking drivers, qcom ipa driver, the rest

STALE1977d

3 messages, 3 authors, 2021-03-15 · open the first message on its own page

[PATCH net-next] net: ipa: make ipa_table_hash_support() inline

From: Alex Elder <hidden>
Date: 2021-03-15 15:02:19

In review, Alexander Duyck suggested that ipa_table_hash_support()
was trivial enough that it could be implemented as a static inline
function in the header file.  But the patch had already been
accepted.  Implement his suggestion.

Signed-off-by: Alex Elder <redacted>
---
 drivers/net/ipa/ipa_table.c | 5 -----
 drivers/net/ipa/ipa_table.h | 5 ++++-
 2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c
index baaab3dd0e63c..7450e27068f19 100644
--- a/drivers/net/ipa/ipa_table.c
+++ b/drivers/net/ipa/ipa_table.c
@@ -239,11 +239,6 @@ static void ipa_table_validate_build(void)
 
 #endif /* !IPA_VALIDATE */
 
-bool ipa_table_hash_support(struct ipa *ipa)
-{
-	return ipa->version != IPA_VERSION_4_2;
-}
-
 /* Zero entry count means no table, so just return a 0 address */
 static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16 count)
 {
diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h
index 1a68d20f19d6a..889c2e93b1223 100644
--- a/drivers/net/ipa/ipa_table.h
+++ b/drivers/net/ipa/ipa_table.h
@@ -55,7 +55,10 @@ static inline bool ipa_filter_map_valid(struct ipa *ipa, u32 filter_mask)
  * ipa_table_hash_support() - Return true if hashed tables are supported
  * @ipa:	IPA pointer
  */
-bool ipa_table_hash_support(struct ipa *ipa);
+static inline bool ipa_table_hash_support(struct ipa *ipa)
+{
+	return ipa->version != IPA_VERSION_4_2;
+}
 
 /**
  * ipa_table_reset() - Reset filter and route tables entries to "none"
-- 
2.27.0

Re: [PATCH net-next] net: ipa: make ipa_table_hash_support() inline

From: Alexander Duyck <hidden>
Date: 2021-03-15 15:12:52

On Mon, Mar 15, 2021 at 8:01 AM Alex Elder [off-list ref] wrote:
In review, Alexander Duyck suggested that ipa_table_hash_support()
was trivial enough that it could be implemented as a static inline
function in the header file.  But the patch had already been
accepted.  Implement his suggestion.

Signed-off-by: Alex Elder <redacted>
Looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
quoted hunk
---
 drivers/net/ipa/ipa_table.c | 5 -----
 drivers/net/ipa/ipa_table.h | 5 ++++-
 2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c
index baaab3dd0e63c..7450e27068f19 100644
--- a/drivers/net/ipa/ipa_table.c
+++ b/drivers/net/ipa/ipa_table.c
@@ -239,11 +239,6 @@ static void ipa_table_validate_build(void)

 #endif /* !IPA_VALIDATE */

-bool ipa_table_hash_support(struct ipa *ipa)
-{
-       return ipa->version != IPA_VERSION_4_2;
-}
-
 /* Zero entry count means no table, so just return a 0 address */
 static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16 count)
 {
diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h
index 1a68d20f19d6a..889c2e93b1223 100644
--- a/drivers/net/ipa/ipa_table.h
+++ b/drivers/net/ipa/ipa_table.h
@@ -55,7 +55,10 @@ static inline bool ipa_filter_map_valid(struct ipa *ipa, u32 filter_mask)
  * ipa_table_hash_support() - Return true if hashed tables are supported
  * @ipa:       IPA pointer
  */
-bool ipa_table_hash_support(struct ipa *ipa);
+static inline bool ipa_table_hash_support(struct ipa *ipa)
+{
+       return ipa->version != IPA_VERSION_4_2;
+}

 /**
  * ipa_table_reset() - Reset filter and route tables entries to "none"
--
2.27.0

Re: [PATCH net-next] net: ipa: make ipa_table_hash_support() inline

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-15 22:01:06

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 15 Mar 2021 10:01:18 -0500 you wrote:
In review, Alexander Duyck suggested that ipa_table_hash_support()
was trivial enough that it could be implemented as a static inline
function in the header file.  But the patch had already been
accepted.  Implement his suggestion.

Signed-off-by: Alex Elder <redacted>

[...]
Here is the summary with links:
  - [net-next] net: ipa: make ipa_table_hash_support() inline
    https://git.kernel.org/netdev/net-next/c/0f13b5e6bf28

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help