[PATCH] bpf: selftests: remove unused 'nospace_err' in tests for batched ops in array maps

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE1993d LANDED

Landed in mainline as 23f50b5ac331 on 2021-03-16.

3 messages, 3 authors, 2021-03-16 · open the first message on its own page

[PATCH] bpf: selftests: remove unused 'nospace_err' in tests for batched ops in array maps

From: Pedro Tammela <hidden>
Date: 2021-03-15 13:32:01

This seems to be a reminiscent from the hashmap tests.

Signed-off-by: Pedro Tammela <redacted>
---
 tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c b/tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c
index f0a64d8ac59a..e42ea1195d18 100644
--- a/tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c
+++ b/tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c
@@ -55,7 +55,6 @@ void test_array_map_batch_ops(void)
 	int map_fd, *keys, *values, *visited;
 	__u32 count, total, total_success;
 	const __u32 max_entries = 10;
-	bool nospace_err;
 	__u64 batch = 0;
 	int err, step;
 	DECLARE_LIBBPF_OPTS(bpf_map_batch_opts, opts,
@@ -90,7 +89,6 @@ void test_array_map_batch_ops(void)
 		 * elements each.
 		 */
 		count = step;
-		nospace_err = false;
 		while (true) {
 			err = bpf_map_lookup_batch(map_fd,
 						total ? &batch : NULL, &batch,
@@ -107,9 +105,6 @@ void test_array_map_batch_ops(void)
 
 		}
 
-		if (nospace_err == true)
-			continue;
-
 		CHECK(total != max_entries, "lookup with steps",
 		      "total = %u, max_entries = %u\n", total, max_entries);
 
-- 
2.25.1

Re: [PATCH] bpf: selftests: remove unused 'nospace_err' in tests for batched ops in array maps

From: Yonghong Song <hidden>
Date: 2021-03-15 16:01:11


On 3/15/21 6:29 AM, Pedro Tammela wrote:
This seems to be a reminiscent from the hashmap tests.

Signed-off-by: Pedro Tammela <redacted>
Acked-by: Yonghong Song <redacted>

Re: [PATCH] bpf: selftests: remove unused 'nospace_err' in tests for batched ops in array maps

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-16 05:30:47

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon, 15 Mar 2021 14:29:51 +0100 you wrote:
This seems to be a reminiscent from the hashmap tests.

Signed-off-by: Pedro Tammela <redacted>
---
 tools/testing/selftests/bpf/map_tests/array_map_batch_ops.c | 5 -----
 1 file changed, 5 deletions(-)
Here is the summary with links:
  - bpf: selftests: remove unused 'nospace_err' in tests for batched ops in array maps
    https://git.kernel.org/bpf/bpf-next/c/23f50b5ac331

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help