# Re: \[PATCH v2 net-next 0/3\] gro: micro-optimize dev\_gro\_receive()

- From: Eric Dumazet \<hidden\>
- Date: 2021-03-15 08:52:13 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/03/6300216
- Thread: https://ratatoskr.run/netdev/2021/03/6299446/t.md

```text
On Sat, Mar 13, 2021 at 9:30 PM Alexander Lobakin [ref] wrote:
>
> This random series addresses some of suboptimal constructions used
> in the main GRO entry point.
> The main body is gro_list_prepare() simplification and pointer usage
> optimization in dev_gro_receive() itself. Being mostly cosmetic, it
> gives like +10 Mbps on my setup to both TCP and UDP (both single- and
> multi-flow).
>
> Since v1 [0]:
>  - drop the replacement of bucket index calculation with
>    reciprocal_scale() since it makes absolutely no sense (Eric);
>  - improve stack usage in dev_gro_receive() (Eric);
>  - reverse the order of patches to avoid changes superseding.
>
> [0] https://lore.kernel.org/netdev/20210312162127.239795-1-alobakin@pm.me
>

SGTM, thanks.

Reviewed-by: Eric Dumazet <redacted>
```