[PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config

Subsystems: ethernet phy library, networking drivers, sff/sfp/sfp+ module support, the rest

STALE1969d

2 messages, 2 authors, 2021-03-15 · open the first message on its own page

[PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config

From: Ong Boon Leong <hidden>
Date: 2021-03-15 04:30:22

if pl->mac_ops->mac_finish() failed, phylink_err should use
"mac_finish" instead of "mac_prepare".

Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS")
Signed-off-by: Ong Boon Leong <redacted>
---
 drivers/net/phy/phylink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 053c92e02cd8..dc2800beacc3 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -476,7 +476,7 @@ static void phylink_major_config(struct phylink *pl, bool restart,
 		err = pl->mac_ops->mac_finish(pl->config, pl->cur_link_an_mode,
 					      state->interface);
 		if (err < 0)
-			phylink_err(pl, "mac_prepare failed: %pe\n",
+			phylink_err(pl, "mac_finish failed: %pe\n",
 				    ERR_PTR(err));
 	}
 }
-- 
2.25.1

Re: [PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-15 20:00:58

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 15 Mar 2021 12:33:42 +0800 you wrote:
if pl->mac_ops->mac_finish() failed, phylink_err should use
"mac_finish" instead of "mac_prepare".

Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS")
Signed-off-by: Ong Boon Leong <redacted>
---
 drivers/net/phy/phylink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - [net,1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config
    https://git.kernel.org/netdev/net/c/d82c6c1aaccd

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help