[PATCH] perf machine: Assign boolean values to a bool variable
Subsystems:
performance events subsystem , the rest
1976d
LANDED
Landed in mainline as 83ff0f93b080 on 2021-03-09.
3 messages,
3 authors,
2021-03-10 · open the first message on its own page
Fix the following coccicheck warnings:
./tools/perf/util/machine.c:2041:9-10: WARNING: return of 0/1 in
function 'symbol__match_regex' with return type bool.
Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
tools/perf/util/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index b5c2d8b..435771e 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c @@ -2038,8 +2038,8 @@ int machine__process_event(struct machine *machine, union perf_event *event,
static bool symbol__match_regex ( struct symbol * sym , regex_t * regex )
{
if ( ! regexec ( regex , sym -> name , 0 , NULL , 0 ))
- return 1 ; - return 0 ; + return true ; + return false ; }
static void ip__resolve_ams ( struct thread * thread , --
1.8.3.1
Em Tue, Mar 09, 2021 at 06:11:09PM +0800, Jiapeng Chong escreveu: Fix the following coccicheck warnings:
./tools/perf/util/machine.c:2041:9-10: WARNING: return of 0/1 in
function 'symbol__match_regex' with return type bool.
Thanks, applied.
- Arnaldo
quoted hunk Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
tools/perf/util/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index b5c2d8b..435771e 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c @@ -2038,8 +2038,8 @@ int machine__process_event(struct machine *machine, union perf_event *event,
static bool symbol__match_regex ( struct symbol * sym , regex_t * regex )
{
if ( ! regexec ( regex , sym -> name , 0 , NULL , 0 ))
- return 1 ; - return 0 ; + return true ; + return false ; }
static void ip__resolve_ams ( struct thread * thread , --
1.8.3.1
--
- Arnaldo
From: Jiapeng Chong quoted hunk Sent: 09 March 2021 10:11
Fix the following coccicheck warnings:
./tools/perf/util/machine.c:2041:9-10: WARNING: return of 0/1 in
function 'symbol__match_regex' with return type bool.
Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
tools/perf/util/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index b5c2d8b..435771e 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c @@ -2038,8 +2038,8 @@ int machine__process_event(struct machine *machine, union perf_event *event,
static bool symbol__match_regex ( struct symbol * sym , regex_t * regex )
{
if ( ! regexec ( regex , sym -> name , 0 , NULL , 0 ))
- return 1 ; - return 0 ; + return true ; + return false ;
What's wrong with:
return !regexec(regex, sym->name, 0, NULL, 0);
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)