[PATCH] net: qrtr: fix error return code of qrtr_sendmsg()

Subsystems: networking [general], qualcomm ipc router (qrtr) driver, the rest

STALE1973d

2 messages, 2 authors, 2021-03-08 · open the first message on its own page

[PATCH] net: qrtr: fix error return code of qrtr_sendmsg()

From: Jia-Ju Bai <hidden>
Date: 2021-03-08 09:14:51

When sock_alloc_send_skb() returns NULL to skb, no error return code of
qrtr_sendmsg() is assigned.
To fix this bug, rc is assigned with -ENOMEM in this case.

Fixes: 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets")
Reported-by: TOTE Robot <redacted>
Signed-off-by: Jia-Ju Bai <redacted>
---
 net/qrtr/qrtr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index b34358282f37..ac2a4a7711da 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -958,8 +958,10 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
 	plen = (len + 3) & ~3;
 	skb = sock_alloc_send_skb(sk, plen + QRTR_HDR_MAX_SIZE,
 				  msg->msg_flags & MSG_DONTWAIT, &rc);
-	if (!skb)
+	if (!skb) {
+		rc = -ENOMEM;
 		goto out_node;
+	}
 
 	skb_reserve(skb, QRTR_HDR_MAX_SIZE);
 
-- 
2.17.1

Re: [PATCH] net: qrtr: fix error return code of qrtr_sendmsg()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-08 23:11:13

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon,  8 Mar 2021 01:13:55 -0800 you wrote:
When sock_alloc_send_skb() returns NULL to skb, no error return code of
qrtr_sendmsg() is assigned.
To fix this bug, rc is assigned with -ENOMEM in this case.

Fixes: 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets")
Reported-by: TOTE Robot <redacted>
Signed-off-by: Jia-Ju Bai <redacted>

[...]
Here is the summary with links:
  - net: qrtr: fix error return code of qrtr_sendmsg()
    https://git.kernel.org/netdev/net/c/179d0ba0c454

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help