[PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

Subsystems: networking drivers, the rest

STALE1977d

2 messages, 2 authors, 2021-03-05 · open the first message on its own page

[PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

From: Denis Efremov <efremov@linux.com>
Date: 2021-03-05 14:29:56

"len > sp->mtu" checked twice in a row in sp_encaps().
Remove the second check.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 drivers/net/hamradio/6pack.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 71d6629e65c9..9f5b5614a150 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -171,11 +171,6 @@ static void sp_encaps(struct sixpack *sp, unsigned char *icp, int len)
 		goto out_drop;
 	}
 
-	if (len > sp->mtu) {	/* sp->mtu = AX25_MTU = max. PACLEN = 256 */
-		msg = "oversized transmit packet!";
-		goto out_drop;
-	}
-
 	if (p[0] > 5) {
 		msg = "invalid KISS command";
 		goto out_drop;
-- 
2.26.2

Re: [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-05 21:11:42

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  5 Mar 2021 19:26:22 +0300 you wrote:
"len > sp->mtu" checked twice in a row in sp_encaps().
Remove the second check.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 drivers/net/hamradio/6pack.c | 5 -----
 1 file changed, 5 deletions(-)
Here is the summary with links:
  - net/hamradio/6pack: remove redundant check in sp_encaps()
    https://git.kernel.org/netdev/net/c/85554bcd123e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help