[PATCH RESEND][next] ice: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 02b12736ea80..207f6ee3a7f6 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c

@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
 	case ICE_RX_PTYPE_INNER_PROT_UDP:
 	case ICE_RX_PTYPE_INNER_PROT_SCTP:
 		skb->ip_summed = CHECKSUM_UNNECESSARY;
+		break;
 	default:
 		break;
 	}

-- 
2.27.0

Dear Gustavo,


Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC 
and clang, and it was decided to go with the “clang decision”, and not 
have clang adapt to GCC.

Kind regards,

Paul

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Paul Menzel
Sent: Friday, March 5, 2021 1:04 AM
To: Gustavo A. R. Silva <gustavoars@kernel.org>; Brandeburg, Jesse
[off-list ref]; Nguyen, Anthony L
[off-list ref]; David S. Miller [off-list ref];
Jakub Kicinski [off-list ref]
Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
hardening@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
warnings for Clang

Dear Gustavo,


Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:

quoted

In preparation to enable -Wimplicit-fallthrough for Clang, fix a
warning by explicitly adding a break statement instead of just letting
the code fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC
and clang, and it was decided to go with the “clang decision”, and not have
clang adapt to GCC.

quoted

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
  drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
  1 file changed, 1 insertion(+)

Tested-by: Tony Brelinski <redacted> A Contingent Worker at Intel