[PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

Subsystems: networking drivers, ocelot ethernet switch driver, the rest

STALE1977d REVIEWED: 6 (6M)

1 review trailer (1 from subsystem maintainers).

3 messages, 2 authors, 2021-03-05 · open the first message on its own page

[PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2021-03-05 07:34:12

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot_vcap.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
index 37a232911395..7945393a0655 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.c
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
@@ -761,6 +761,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
 			vcap_key_bytes_set(vcap, &data, VCAP_IS1_HK_ETYPE,
 					   etype.value, etype.mask);
 		}
+		break;
 	}
 	default:
 		break;
-- 
2.27.0

Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

From: David Miller <davem@davemloft.net>
Date: 2021-03-05 20:49:24

Please resubmit these again when net-next opens back up, thank you.

Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2021-03-05 22:38:44

On Fri, Mar 05, 2021 at 12:48:12PM -0800, David Miller wrote:
Please resubmit these again when net-next opens back up, thank you.
Sure thing.

Thanks
--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help