# Re: \[PATCH 043/141\] net: cassini: Fix fall-through warnings for Clang

- From: Gustavo A. R. Silva \<gustavoars@kernel.org\>
- Date: 2021-03-04 22:52:09 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/03/6288869
- Thread: https://ratatoskr.run/netdev/2020/11/6184556/t/2.md

```text
Hi all,

It's been more than 3 months; who can take this, please? :)

Thanks
--
Gustavo

On Fri, Nov 20, 2020 at 12:31:02PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  drivers/net/ethernet/sun/cassini.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
> index 9ff894ba8d3e..54f45d8c79a7 100644
> --- a/drivers/net/ethernet/sun/cassini.c
> +++ b/drivers/net/ethernet/sun/cassini.c
> @@ -1599,6 +1599,7 @@ static inline int cas_mdio_link_not_up(struct cas *cp)
>  			cas_phy_write(cp, MII_BMCR, val);
>  			break;
>  		}
> +		break;
>  	default:
>  		break;
>  	}
> -- 
> 2.27.0
> 
```