[PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()

Subsystems: networking [general], the rest, tipc network layer

STALE1950d

2 messages, 2 authors, 2021-03-31 · open the first message on its own page

[PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()

From: Yang Yingliang <hidden>
Date: 2021-03-31 08:33:51

Add the missing destroy_workqueue() before return from
tipc_crypto_start() in the error handling case.

Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
---
 net/tipc/crypto.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c
index 6f64acef73dc..76b8428c94a7 100644
--- a/net/tipc/crypto.c
+++ b/net/tipc/crypto.c
@@ -1492,6 +1492,8 @@ int tipc_crypto_start(struct tipc_crypto **crypto, struct net *net,
 	/* Allocate statistic structure */
 	c->stats = alloc_percpu_gfp(struct tipc_crypto_stats, GFP_ATOMIC);
 	if (!c->stats) {
+		if (c->wq)
+			destroy_workqueue(c->wq);
 		kfree_sensitive(c);
 		return -ENOMEM;
 	}
-- 
2.25.1

Re: [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-31 22:21:18

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 31 Mar 2021 16:36:02 +0800 you wrote:
Add the missing destroy_workqueue() before return from
tipc_crypto_start() in the error handling case.

Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>

[...]
Here is the summary with links:
  - [-next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()
    https://git.kernel.org/netdev/net-next/c/ac1db7acea67

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help