Re: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

4 messages, 3 authors, 2021-08-16 · open the first message on its own page

Re: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

From: Eric Dumazet <edumazet@google.com>
Date: 2021-03-31 05:59:18

On Wed, Mar 31, 2021 at 2:01 AM Wong, Vee Khee [off-list ref] wrote:

Hi all,



This patch introduced the following massive warnings printouts on a

Intel x86 Alderlake platform with STMMAC MAC and Marvell 88E2110 PHY.



[  149.674232] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  159.930310] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  170.186205] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  180.434311] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  190.682309] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  200.690176] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  210.938310] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  221.186311] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  231.442311] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  241.690186] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  251.698288] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  261.946311] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  272.194181] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  282.442311] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  292.690310] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  302.938313] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  313.186255] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  323.442329] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  333.698309] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  343.946310] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  354.202166] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  364.450190] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

[  374.706314] unregister_netdevice: waiting for sit0 to become free. Usage count = 2



Is this an expected behavior?



Thanks,

VK

Same answer than the other thread :

Nope, I already have a fix, but it depends on a pending patch.

https://patchwork.kernel.org/project/netdevbpf/patch/20210330064551.545964-1-eric.dumazet@gmail.com/

(I need the patch being merged to add a corresponding Fixes: tag)

You can try the attached patch :

RE: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

From: Wong, Vee Khee <hidden>
Date: 2021-03-31 08:52:44

On Wed, Mar 31, 2021 at 13:58, Eric Dumazet wrote:

On Wed, Mar 31, 2021 at 2:01 AM Wong, Vee Khee
[off-list ref] wrote:

quoted

Hi all,



This patch introduced the following massive warnings printouts on a

Intel x86 Alderlake platform with STMMAC MAC and Marvell 88E2110 PHY.



[  149.674232] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  159.930310] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  170.186205] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  180.434311] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  190.682309] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  200.690176] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  210.938310] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  221.186311] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  231.442311] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  241.690186] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  251.698288] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  261.946311] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  272.194181] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  282.442311] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  292.690310] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  302.938313] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  313.186255] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  323.442329] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  333.698309] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  343.946310] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  354.202166] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  364.450190] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted

[  374.706314] unregister_netdevice: waiting for sit0 to become free.

Usage count = 2

quoted



Is this an expected behavior?



Thanks,

VK

Same answer than the other thread :

Nope, I already have a fix, but it depends on a pending patch.

https://patchwork.kernel.org/project/netdevbpf/patch/20210330064551.54
5964-1-eric.dumazet@gmail.com/

(I need the patch being merged to add a corresponding Fixes: tag)

You can try the attached patch :

Thanks, I applied the two patches you mentioned and
no longer seeing the warnings.

Re: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

From: Eric Dumazet <edumazet@google.com>
Date: 2021-03-31 09:03:38

On Wed, Mar 31, 2021 at 10:52 AM Wong, Vee Khee [off-list ref] wrote:

On Wed, Mar 31, 2021 at 13:58, Eric Dumazet wrote:

quoted

Nope, I already have a fix, but it depends on a pending patch.

https://patchwork.kernel.org/project/netdevbpf/patch/20210330064551.54
5964-1-eric.dumazet@gmail.com/

(I need the patch being merged to add a corresponding Fixes: tag)

You can try the attached patch :

Thanks, I applied the two patches you mentioned and
no longer seeing the warnings.

Thanks for testing !

Re: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

From: Alarig Le Lay <hidden>
Date: 2021-08-16 15:20:33

Hi,

On Wed 31 Mar 2021 07:58:07 GMT, Eric Dumazet wrote:

On Wed, Mar 31, 2021 at 2:01 AM Wong, Vee Khee [off-list ref] wrote:

quoted

Hi all,



This patch introduced the following massive warnings printouts on a

Intel x86 Alderlake platform with STMMAC MAC and Marvell 88E2110 PHY.



[  149.674232] unregister_netdevice: waiting for sit0 to become free. Usage count = 2

Same answer than the other thread :

Nope, I already have a fix, but it depends on a pending patch.

https://patchwork.kernel.org/project/netdevbpf/patch/20210330064551.545964-1-eric.dumazet@gmail.com/

(I need the patch being merged to add a corresponding Fixes: tag)

You can try the attached patch :

I’ve upgraded some boxes to 4.14.240 which includes the fix, but I have

unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1

every ten seconds.

It’s not the same interface name nor the same count, so perhaps there is
another issue with the patches?

Regards,
-- 
Alarig Le Lay

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help