[RESEND net-next 0/4] net: remove repeated words
10 messages,
6 authors,
2021-03-31 · open the first message on its own page
This patch-set removes some repeated words in comments.
Peng Li (4):
net: i40e: remove repeated words
net: bonding: remove repeated word
net: phy: remove repeated word
net: ipa: remove repeated words
drivers/net/bonding/bond_alb.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
drivers/net/ipa/ipa_endpoint.c | 4 ++--
drivers/net/phy/mdio_bus.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
--
2.7.4
From: Peng Li <redacted>
Remove repeated word "to".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
---
drivers/net/phy/mdio_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 8235185..dadf75f 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c @@ -510,7 +510,7 @@ static int mdiobus_create_device(struct mii_bus *bus,
* on a given bus , and attach them to the bus . Drivers should use
* mdiobus_register () rather than __mdiobus_register () unless they
* need to pass a specific owner module . MDIO devices which are not
- * PHYs will not be brought up by this function . They are expected to
+ * PHYs will not be brought up by this function . They are expected
* to be explicitly listed in DT and instantiated by of_mdiobus_register ().
*
* Returns 0 on success or < 0 on error . --
2.7.4
From: Peng Li <redacted>
Remove repeated words "to" and "try".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 0f84ed0..1555d60 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -7339,7 +7339,7 @@ static void i40e_vsi_set_default_tc_config(struct i40e_vsi *vsi)
qcount = min_t ( int , vsi -> alloc_queue_pairs ,
i40e_pf_get_max_q_per_tc ( vsi -> back ));
for ( i = 0 ; i < I40E_MAX_TRAFFIC_CLASS ; i ++ ) {
- /* For the TC that is not enabled set the offset to to default
+ /* For the TC that is not enabled set the offset to default
* queue and allocate one queue for the given TC .
*/
vsi -> tc_config . tc_info [ i ]. qoffset = 0 ; @@ -10625,7 +10625,7 @@ static void i40e_rebuild(struct i40e_pf *pf, bool reinit, bool lock_acquired)
* need to rebuild the switch model in the HW .
*
* If there were VEBs but the reconstitution failed , we ' ll try
- * try to recover minimal use by getting the basic PF VSI working .
+ * to recover minimal use by getting the basic PF VSI working .
*/
if ( vsi -> uplink_seid != pf -> mac_seid ) {
dev_dbg ( & pf -> pdev -> dev , "attempting to rebuild switch \n " ); --
2.7.4
From: Peng Li <redacted>
Remove repeated word "that".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
---
drivers/net/bonding/bond_alb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index c3091e0..3455f2c 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c @@ -1098,7 +1098,7 @@ static void alb_fasten_mac_swap(struct bonding *bond, struct slave *slave1,
* If @ slave ' s permanent hw address is different both from its current
* address and from @ bond ' s address , then somewhere in the bond there ' s
* a slave that has @ slave ' s permanet address as its current address .
- * We ' ll make sure that that slave no longer uses @ slave ' s permanent address .
+ * We ' ll make sure that slave no longer uses @ slave ' s permanent address .
*
* Caller must hold RTNL and no other locks
*/ --
2.7.4
From: Peng Li <redacted>
Remove repeated words "that" and "the".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
---
drivers/net/ipa/ipa_endpoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 38e83cd..dd24179 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c @@ -809,7 +809,7 @@ static u32 hol_block_timer_val(struct ipa *ipa, u32 microseconds)
* The best precision is achieved when the base value is as
* large as possible . Find the highest set bit in the tick
* count , and extract the number of bits in the base field
- * such that that high bit is included .
+ * such that high bit is included .
*/
high = fls ( ticks ); /* 1..32 */
width = HWEIGHT32 ( BASE_VALUE_FMASK ); @@ -1448,7 +1448,7 @@ static int ipa_endpoint_reset_rx_aggr(struct ipa_endpoint *endpoint)
if ( ret )
goto out_suspend_again ;
- /* Finally, reset and reconfigure the channel again (re-enabling the
+ /* Finally, reset and reconfigure the channel again (re-enabling
* the doorbell engine if appropriate ). Sleep for 1 millisecond to
* complete the channel reset sequence . Finish by suspending the
* channel again ( if necessary ). --
2.7.4
On 3/30/21 2:27 AM, Huazhong Tan wrote: From: Peng Li <redacted>
Remove repeated words "that" and "the".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
Acked-by: Alex Elder <redacted>
quoted hunk ---
drivers/net/ipa/ipa_endpoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 38e83cd..dd24179 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c @@ -809,7 +809,7 @@ static u32 hol_block_timer_val(struct ipa *ipa, u32 microseconds)
* The best precision is achieved when the base value is as
* large as possible . Find the highest set bit in the tick
* count , and extract the number of bits in the base field
- * such that that high bit is included .
+ * such that high bit is included .
*/
high = fls ( ticks ); /* 1..32 */
width = HWEIGHT32 ( BASE_VALUE_FMASK ); @@ -1448,7 +1448,7 @@ static int ipa_endpoint_reset_rx_aggr(struct ipa_endpoint *endpoint)
if ( ret )
goto out_suspend_again ;
- /* Finally, reset and reconfigure the channel again (re-enabling the
+ /* Finally, reset and reconfigure the channel again (re-enabling
* the doorbell engine if appropriate ). Sleep for 1 millisecond to
* complete the channel reset sequence . Finish by suspending the
* channel again ( if necessary ).
On Tue, Mar 30, 2021 at 03:27:55PM +0800, Huazhong Tan wrote: From: Peng Li <redacted>
Remove repeated word "to".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
Huazhong Tan [off-list ref] wrote:
quoted hunk From: Peng Li <redacted>
Remove repeated word "that".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>
---
drivers/net/bonding/bond_alb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index c3091e0..3455f2c 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c @@ -1098,7 +1098,7 @@ static void alb_fasten_mac_swap(struct bonding *bond, struct slave *slave1,
* If @ slave ' s permanent hw address is different both from its current
* address and from @ bond ' s address , then somewhere in the bond there ' s
* a slave that has @ slave ' s permanet address as its current address .
- * We ' ll make sure that that slave no longer uses @ slave ' s permanent address .
+ * We ' ll make sure that slave no longer uses @ slave ' s permanent address .
This is actually correct as written, but I can see that it's a
bit confusing. Rather than removing the second that, I'd suggest
changing it to "... make sure the other slave no longer uses ..." to be
clearer.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
On 3/30/21 12:27 AM, Huazhong Tan wrote: From: Peng Li <redacted>
Remove repeated words "to" and "try".
Signed-off-by: Peng Li <redacted>
Signed-off-by: Huazhong Tan <redacted>\
Hi,
quoted hunk ---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 0f84ed0..1555d60 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -7339,7 +7339,7 @@ static void i40e_vsi_set_default_tc_config(struct i40e_vsi *vsi)
qcount = min_t ( int , vsi -> alloc_queue_pairs ,
i40e_pf_get_max_q_per_tc ( vsi -> back ));
for ( i = 0 ; i < I40E_MAX_TRAFFIC_CLASS ; i ++ ) {
- /* For the TC that is not enabled set the offset to to default
+ /* For the TC that is not enabled set the offset to default
I think that offset to the default
would be clearer. IMO.
* queue and allocate one queue for the given TC.
*/
vsi->tc_config.tc_info[i].qoffset = 0;
thanks.
--
~Randy
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 30 Mar 2021 15:27:52 +0800 you wrote: This patch-set removes some repeated words in comments.
Peng Li (4):
net: i40e: remove repeated words
net: bonding: remove repeated word
net: phy: remove repeated word
net: ipa: remove repeated words
[...]
Here is the summary with links:
- [RESEND,net-next,1/4] net: i40e: remove repeated words
https://git.kernel.org/netdev/net-next/c/059ff70c8cab
- [RESEND,net-next,2/4] net: bonding: remove repeated word
https://git.kernel.org/netdev/net-next/c/252b5d373564
- [RESEND,net-next,3/4] net: phy: remove repeated word
https://git.kernel.org/netdev/net-next/c/fec76125baf7
- [RESEND,net-next,4/4] net: ipa: remove repeated words
https://git.kernel.org/netdev/net-next/c/497abc87cf99
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html