[PATCH -next] net: stmmac: fix missing unlock on error in stmmac_suspend()

Subsystems: networking drivers, stmmac ethernet driver, the rest

STALE1954d

2 messages, 2 authors, 2021-03-29 · open the first message on its own page

[PATCH -next] net: stmmac: fix missing unlock on error in stmmac_suspend()

From: Yang Yingliang <hidden>
Date: 2021-03-27 09:30:59

Add the missing unlock before return from stmmac_suspend()
in the error handling case.

Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 170296820af0..973bdf11e59d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -5605,8 +5605,10 @@ int stmmac_suspend(struct device *dev)
 		/* Disable clock in case of PWM is off */
 		clk_disable_unprepare(priv->plat->clk_ptp_ref);
 		ret = pm_runtime_force_suspend(dev);
-		if (ret)
+		if (ret) {
+			mutex_unlock(&priv->lock);
 			return ret;
+		}
 	}
 
 	mutex_unlock(&priv->lock);
-- 
2.25.1

Re: [PATCH -next] net: stmmac: fix missing unlock on error in stmmac_suspend()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-29 01:11:04

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 17:33:22 +0800 you wrote:
Add the missing unlock before return from stmmac_suspend()
in the error handling case.

Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>

[...]
Here is the summary with links:
  - [-next] net: stmmac: fix missing unlock on error in stmmac_suspend()
    https://git.kernel.org/netdev/net-next/c/30f347ae7cc1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help