[PATCH net-next] farsync: use DEFINE_SPINLOCK() for spinlock

Subsystems: farsync synchronous driver, networking drivers, the rest

STALE1958d

2 messages, 2 authors, 2021-03-26 · open the first message on its own page

[PATCH net-next] farsync: use DEFINE_SPINLOCK() for spinlock

From: 'Liu Jian <hidden>
Date: 2021-03-26 12:31:11

From: Liu Jian <redacted>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Liu Jian <redacted>
---
 drivers/net/wan/farsync.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 686a25d3b512..5de71e44fc5a 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -573,7 +573,7 @@ static DECLARE_TASKLET(fst_tx_task, fst_process_tx_work_q);
 static DECLARE_TASKLET(fst_int_task, fst_process_int_work_q);
 
 static struct fst_card_info *fst_card_array[FST_MAX_CARDS];
-static spinlock_t fst_work_q_lock;
+static DEFINE_SPINLOCK(fst_work_q_lock);
 static u64 fst_work_txq;
 static u64 fst_work_intq;
 
@@ -2648,7 +2648,6 @@ fst_init(void)
 
 	for (i = 0; i < FST_MAX_CARDS; i++)
 		fst_card_array[i] = NULL;
-	spin_lock_init(&fst_work_q_lock);
 	return pci_register_driver(&fst_driver);
 }
 

Re: [PATCH net-next] farsync: use DEFINE_SPINLOCK() for spinlock

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-26 23:01:16

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 26 Mar 2021 20:31:38 +0800 you wrote:
From: Liu Jian <redacted>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Liu Jian <redacted>

[...]
Here is the summary with links:
  - [net-next] farsync: use DEFINE_SPINLOCK() for spinlock
    https://git.kernel.org/netdev/net-next/c/a1281601f88e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help