# Re: \[RFC PATCH V2 net-next 1/5\] ethtool: Allow network drivers to dump arbitrary EEPROM data

- From: Moshe Shemesh \<hidden\>
- Date: 2021-03-08 08:55:01 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/03/11197932
- Thread: https://ratatoskr.run/netdev/2021/03/11197785/t.md

```text

On 3/5/2021 3:58 AM, Andrew Lunn wrote:
>
>> +/* MODULE EEPROM DATA */
>> +
>> +enum {
>> +     ETHTOOL_A_EEPROM_DATA_UNSPEC,
>> +     ETHTOOL_A_EEPROM_DATA_HEADER,
>> +
>> +     ETHTOOL_A_EEPROM_DATA_OFFSET,
>> +     ETHTOOL_A_EEPROM_DATA_LENGTH,
>> +     ETHTOOL_A_EEPROM_DATA_PAGE,
>> +     ETHTOOL_A_EEPROM_DATA_BANK,
>> +     ETHTOOL_A_EEPROM_DATA_I2C_ADDRESS,
>> +     ETHTOOL_A_EEPROM_DATA,
> If you look at all the other such enums in ethtool_netlink, you will
> see a comment indicating the type. Please add them here as well.
>
> Please also update Documentation/networking/ethtool-netlink.rst.
Sure, will add.
>         Andrew
```