# Re: \[Patch bpf-next v6 5/8\] sock\_map: rename skb\_parser and skb\_verdict

- From: Cong Wang \<hidden\>
- Date: 2021-02-22 19:35:09 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/02/7761257
- Thread: https://ratatoskr.run/netdev/2021/02/7760707/t.md

```text
On Mon, Feb 22, 2021 at 4:28 AM Jakub Sitnicki [ref] wrote:
>
> skb_parser also appears in:
>
> tools/testing/selftests/bpf/test_sockmap.c:int txmsg_omit_skb_parser;
> tools/testing/selftests/bpf/test_sockmap.c:     {"txmsg_omit_skb_parser", no_argument,      &txmsg_omit_skb_parser, 1},
> tools/testing/selftests/bpf/test_sockmap.c:     txmsg_omit_skb_parser = 0;
> tools/testing/selftests/bpf/test_sockmap.c:     if (!txmsg_omit_skb_parser) {
> tools/testing/selftests/bpf/test_sockmap.c:             if (!txmsg_omit_skb_parser) {
> tools/testing/selftests/bpf/test_sockmap.c:     /* Tests that omit skb_parser */
> tools/testing/selftests/bpf/test_sockmap.c:     txmsg_omit_skb_parser = 1;
> tools/testing/selftests/bpf/test_sockmap.c:     txmsg_omit_skb_parser = 0;

These are harmless, because they are internal variables of a self test.
So, I prefer to just leave them as they are.

Thanks.
```