[PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE1998d LANDED

Landed in mainline as 90a82b1fa40d on 2021-02-12.

6 messages, 4 authors, 2021-02-12 · open the first message on its own page

[PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: Stanislav Fomichev <hidden>
Date: 2021-02-12 01:01:53

There is what I see after compiling the kernel:

 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>
---
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
 /fixdep
 /resolve_btfids
+/libbpf/
-- 
2.30.0.478.g8a0d178c01-goog

Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: Andrii Nakryiko <hidden>
Date: 2021-02-12 19:49:57

On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev [off-list ref] wrote:
There is what I see after compiling the kernel:
typo: This?
 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>
---
Jiri,

Is this

Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
in separate directories")

?

Do we need similar stuff for libsubcmd (what's that, btw?)
quoted hunk
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
 /fixdep
 /resolve_btfids
+/libbpf/
--
2.30.0.478.g8a0d178c01-goog

Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: Stanislav Fomichev <hidden>
Date: 2021-02-12 19:57:25

On Fri, Feb 12, 2021 at 11:48 AM Andrii Nakryiko
[off-list ref] wrote:
On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev [off-list ref] wrote:
quoted
There is what I see after compiling the kernel:
typo: This?
Yes, sure.

quoted
 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>
---
Jiri,

Is this

Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
in separate directories")

?

Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are
ignored in the root .gitignore).
I assume libbpf/ has an issue because there is bpf_helper_defs.h in
that libbpf/ directory.
Not sure why it was removed in fc6b48f692f8 rather than being prefixed
with libbpf/ directory.
I'll leave it up to Jiri to comment.

quoted
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
 /fixdep
 /resolve_btfids
+/libbpf/
--
2.30.0.478.g8a0d178c01-goog

Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: Jiri Olsa <hidden>
Date: 2021-02-12 21:06:31

On Fri, Feb 12, 2021 at 11:48:46AM -0800, Andrii Nakryiko wrote:
On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev [off-list ref] wrote:
quoted
There is what I see after compiling the kernel:
typo: This?
quoted
 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>
---
Jiri,

Is this

Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
in separate directories")
yes
?

Do we need similar stuff for libsubcmd (what's that, btw?)
as Stanislav said it's only .o files in there, so there's no need

it provides the parse_options functionality

jirka
quoted
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
 /fixdep
 /resolve_btfids
+/libbpf/
--
2.30.0.478.g8a0d178c01-goog

Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: Jiri Olsa <hidden>
Date: 2021-02-12 21:07:21

On Fri, Feb 12, 2021 at 11:56:29AM -0800, Stanislav Fomichev wrote:
On Fri, Feb 12, 2021 at 11:48 AM Andrii Nakryiko
[off-list ref] wrote:
quoted
On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev [off-list ref] wrote:
quoted
There is what I see after compiling the kernel:
typo: This?
Yes, sure.

quoted
quoted
 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>
---
Jiri,

Is this

Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
in separate directories")

?

Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are
ignored in the root .gitignore).
I assume libbpf/ has an issue because there is bpf_helper_defs.h in
that libbpf/ directory.
Not sure why it was removed in fc6b48f692f8 rather than being prefixed
with libbpf/ directory.
I'll leave it up to Jiri to comment.
you're right, thanks for the fix

jirka
quoted
quoted
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
 /fixdep
 /resolve_btfids
+/libbpf/
--
2.30.0.478.g8a0d178c01-goog

Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-02-12 21:11:07

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 11 Feb 2021 17:00:53 -0800 you wrote:
There is what I see after compiling the kernel:

 # bpf-next...bpf-next/master
 ?? tools/bpf/resolve_btfids/libbpf/

Signed-off-by: Stanislav Fomichev <redacted>

[...]
Here is the summary with links:
  - [bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
    https://git.kernel.org/bpf/bpf-next/c/90a82b1fa40d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help