Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

Pkshih [off-list ref] writes:

quoted

quoted

--- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c

@@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = {

 	.id_table = rtw_8822ce_id_table,
 	.probe = rtw_pci_probe,
 	.remove = rtw_pci_remove,
-	.driver.pm = &rtw_pm_ops,

Why just 8822ce? Why not remove rtw_pm_ops entirely if it just creates
problems?

I think we can't remove rtw_pm_ops, because wowlan will not work.

Ah. A comment code in the code stating that would be nice.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote:

Pkshih [off-list ref] writes:

quoted

quoted

quoted

--- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c

@@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = {

 	.id_table = rtw_8822ce_id_table,
 	.probe = rtw_pci_probe,
 	.remove = rtw_pci_remove,
-	.driver.pm = &rtw_pm_ops,

Why just 8822ce? Why not remove rtw_pm_ops entirely if it just creates
problems?

I think we can't remove rtw_pm_ops, because wowlan will not work.

Ah. A comment code in the code stating that would be nice.

I'll do it. 
Thanks.