[PATCH] net/mlx5: remove unneeded semicolon

Subsystems: mellanox mlx5 core vpi driver, networking drivers, the rest

STALE1970d

4 messages, 3 authors, 2021-03-11 · open the first message on its own page

[PATCH] net/mlx5: remove unneeded semicolon

From: Jiapeng Chong <hidden>
Date: 2021-02-22 09:58:28

Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block *nb, unsigned long event, voi
 		break;
 	default:
 		break;
-	};
+	}
 
 	return 0;
 }
-- 
1.8.3.1

RE: [PATCH] net/mlx5: remove unneeded semicolon

From: Parav Pandit <hidden>
Date: 2021-02-22 10:07:14

quoted hunk
From: Jiapeng Chong <redacted>
Sent: Monday, February 22, 2021 3:27 PM

Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
*nb, unsigned long event, voi
 		break;
 	default:
 		break;
-	};
+	}

 	return 0;
 }
--
1.8.3.1
Reviewed-by: Parav Pandit <redacted>

RE: [PATCH] net/mlx5: remove unneeded semicolon

From: Parav Pandit <hidden>
Date: 2021-03-03 16:41:41

Hi Saeed,
From: Parav Pandit <redacted>
Sent: Monday, February 22, 2021 3:32 PM

quoted
From: Jiapeng Chong <redacted>
Sent: Monday, February 22, 2021 3:27 PM

Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
Unneeded semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
*nb, unsigned long event, voi
 		break;
 	default:
 		break;
-	};
+	}

 	return 0;
 }
--
1.8.3.1
Reviewed-by: Parav Pandit <redacted>
Will you take this patch [1] to your queue?

[1] https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/

Re: [PATCH] net/mlx5: remove unneeded semicolon

From: Saeed Mahameed <saeed@kernel.org>
Date: 2021-03-11 23:26:03

On Wed, 2021-03-03 at 08:52 +0000, Parav Pandit wrote:
Hi Saeed,
quoted
From: Parav Pandit <redacted>
Sent: Monday, February 22, 2021 3:32 PM

quoted
From: Jiapeng Chong <redacted>
Sent: Monday, February 22, 2021 3:27 PM

Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
Unneeded semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct
notifier_block
*nb, unsigned long event, voi
                break;
        default:
                break;
-       };
+       }

        return 0;
 }
--
1.8.3.1
Reviewed-by: Parav Pandit <redacted>
Will you take this patch [1] to your queue?

[1]
https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/
Applied to net-next-mlx5.
Thanks,
Saeed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help