[PATCH] netdevsim: fib: remove unneeded semicolon

Subsystems: netdevsim, networking drivers, the rest

STALE1989d

2 messages, 2 authors, 2021-02-22 · open the first message on its own page

[PATCH] netdevsim: fib: remove unneeded semicolon

From: Jiapeng Chong <hidden>
Date: 2021-02-22 09:48:52

Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/netdevsim/fib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..11b43ce 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
 err_fib6_rt_nh_del:
 	for (i--; i >= 0; i--) {
 		nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
-	};
+	}
 	nsim_fib_rt_fini(&fib6_rt->common);
 	kfree(fib6_rt);
 	return ERR_PTR(err);
-- 
1.8.3.1

Re: [PATCH] netdevsim: fib: remove unneeded semicolon

From: Ido Schimmel <hidden>
Date: 2021-02-22 10:03:53

On Mon, Feb 22, 2021 at 05:47:04PM +0800, Jiapeng Chong wrote:
quoted hunk
Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/netdevsim/fib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..11b43ce 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
 err_fib6_rt_nh_del:
 	for (i--; i >= 0; i--) {
 		nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
-	};
+	}
You can simply remove the braces since they are not needed
 	nsim_fib_rt_fini(&fib6_rt->common);
 	kfree(fib6_rt);
 	return ERR_PTR(err);
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help