[PATCH] ethernet/microchip:remove unneeded variable: "ret"

Subsystems: networking drivers, the rest

STALE1988d

2 messages, 2 authors, 2021-02-23 · open the first message on its own page

[PATCH] ethernet/microchip:remove unneeded variable: "ret"

From: <hidden>
Date: 2021-02-22 03:00:59

From: dingsenjie <redacted>

remove unneeded variable: "ret".

Signed-off-by: dingsenjie <redacted>
---
 drivers/net/ethernet/microchip/encx24j600.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index 2c0dcd7..a66a179 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -222,7 +222,6 @@ static int encx24j600_wait_for_autoneg(struct encx24j600_priv *priv)
 	unsigned long timeout = jiffies + msecs_to_jiffies(2000);
 	u16 phstat1;
 	u16 estat;
-	int ret = 0;
 
 	phstat1 = encx24j600_read_phy(priv, PHSTAT1);
 	while ((phstat1 & ANDONE) == 0) {
@@ -258,7 +257,7 @@ static int encx24j600_wait_for_autoneg(struct encx24j600_priv *priv)
 		encx24j600_write_reg(priv, MACLCON, 0x370f);
 	}
 
-	return ret;
+	return 0;
 }
 
 /* Access the PHY to determine link status */
-- 
1.9.1

Re: [PATCH] ethernet/microchip:remove unneeded variable: "ret"

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-23 00:46:29

On Mon, 22 Feb 2021 10:58:18 +0800 dingsenjie@163.com wrote:
From: dingsenjie <redacted>

remove unneeded variable: "ret".

Signed-off-by: dingsenjie <redacted>
# Form letter - net-next is closed

We have already sent the networking pull request for 5.12 and therefore
net-next is closed for new drivers, features, code refactoring and
optimizations. We are currently accepting bug fixes only.

Please repost when net-next reopens after 5.12-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help