Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

Hi Jakub,

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Tuesday, February 9, 2021 11:56 PM
To: Hariprasad Kelam <redacted>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
davem@davemloft.net; willemdebruijn.kernel@gmail.com;
andrew@lunn.ch; Sunil Kovvuri Goutham [off-list ref]; Linu
Cherian [off-list ref]; Geethasowjanya Akula
[off-list ref]; Jerin Jacob Kollanukkaran [off-list ref];
Subbaraya Sundeep Bhatta [off-list ref]
Subject: [EXT] Re: [Patch v4 net-next 0/7] ethtool support for fec and link
configuration

On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:

quoted

v4:
	- Corrected indentation issues
	- Use FEC_OFF if user requests for FEC_AUTO mode
	- Do not clear fec stats in case of user changes
	  fec mode
	- dont hide fec stats depending on interface mode
	  selection

What about making autoneg modes symmetric between set and get?

Get supports multi modes such that user can select one of the modes to advertise.
For time being set only supports single mode. Do let me know if you want me to
Add this in commit description.

Thanks,
Hariprasad k

On Wed, 10 Feb 2021 17:06:29 +0000 Hariprasad Kelam wrote:

quoted

On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:  

quoted

v4:
	- Corrected indentation issues
	- Use FEC_OFF if user requests for FEC_AUTO mode
	- Do not clear fec stats in case of user changes
	  fec mode
	- dont hide fec stats depending on interface mode
	  selection  

What about making autoneg modes symmetric between set and get?  

Get supports multi modes such that user can select one of the modes
to advertise. For time being set only supports single mode. Do let me
know if you want me to Add this in commit description.

You use the same code for supported and advertising.
Please add a check that there is only one advertising mode 
reported so we don't have to take your word for it.

Thanks.