# Re: \[PATCH\] i2c: mv64xxx: Fix check for missing clock

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2021-02-08 13:24:55 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/02/6262360
- Thread: https://ratatoskr.run/netdev/2021/02/6261882/t.md

```text
On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote:
> On 2/8/21 12:28 AM, Samuel Holland wrote:
> > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> > pointers to optional clocks were replaced by NULL to simplify the resume
> > callback implementation. However, that commit missed that the IS_ERR
> > check in mv64xxx_of_config should be replaced with a NULL check. As a
> > result, the check always passes, even for an invalid device tree.
> 
> Sorry, please ignore this unrelated patch. I accidentally copied it to
> the wrong directory before sending this series.

Hi Samuel

This patch looks correct. But i don't see it in i2c/for-next, where as
e5c02cf54154 is. I just want to make sure it does not get lost...

	     Andrew
```
