[PATCH] selftests: bpf: remove unneeded semicolon

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE2029d LANDED

Landed in mainline as 11da9f0c6d14 on 2021-02-09.

2 messages, 2 authors, 2021-02-09 · open the first message on its own page

[PATCH] selftests: bpf: remove unneeded semicolon

From: Yang Li <hidden>
Date: 2021-02-08 10:41:28

Eliminate the following coccicheck warning:
./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
index 01f0c63..571cc07 100644
--- a/tools/testing/selftests/bpf/test_flow_dissector.c
+++ b/tools/testing/selftests/bpf/test_flow_dissector.c
@@ -503,7 +503,7 @@ static int do_rx(int fd)
 		if (rbuf != cfg_payload_char)
 			error(1, 0, "recv: payload mismatch");
 		num++;
-	};
+	}
 
 	return num;
 }
-- 
1.8.3.1

Re: [PATCH] selftests: bpf: remove unneeded semicolon

From: Andrii Nakryiko <hidden>
Date: 2021-02-09 02:06:22

On Mon, Feb 8, 2021 at 2:30 AM Yang Li [off-list ref] wrote:
Eliminate the following coccicheck warning:
./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
Applied to bpf-next, changing subject to have more canonical
"selftests/bpf: " prefix. Thanks.
quoted hunk
 tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
index 01f0c63..571cc07 100644
--- a/tools/testing/selftests/bpf/test_flow_dissector.c
+++ b/tools/testing/selftests/bpf/test_flow_dissector.c
@@ -503,7 +503,7 @@ static int do_rx(int fd)
                if (rbuf != cfg_payload_char)
                        error(1, 0, "recv: payload mismatch");
                num++;
-       };
+       }

        return num;
 }
--
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help