Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

Hi Jakub,

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Saturday, February 6, 2021 12:56 AM
To: Hariprasad Kelam <redacted>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
davem@davemloft.net; willemdebruijn.kernel@gmail.com;
andrew@lunn.ch; Sunil Kovvuri Goutham [off-list ref]; Linu
Cherian [off-list ref]; Geethasowjanya Akula
[off-list ref]; Jerin Jacob Kollanukkaran [off-list ref];
Subbaraya Sundeep Bhatta [off-list ref]
Subject: [EXT] Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link
configuration

On Fri, 5 Feb 2021 14:15:01 +0000 Hariprasad Kelam wrote:

quoted

quoted

quoted

Will add multi advertised mode support in near future.

Looking at patch 6 it seems like the get side already supports
multiple modes, although the example output only lists supported no

advertised.

quoted

quoted

Is the device actually doing IEEE autoneg or just configures the
speed, lanes etc. according to the link mode selected?

Device supports IEEE autoneg mode. Agreed get_link_ksetting returns

multiple modes .

quoted

But set side  firmware code designed in such way that  it handles
single mode. Upon Successful configuration firmware updates advertised
modes to shared memory  such that kernel will read and updates to

ethtool.

It needs to be symmetric, get needs to reflect what set specified.

Agreed.  Even though set supports single mode still it is displayed with get link settings.

Thanks,
Hariprasad k