[PATCH net-next] cfg80211: remove unused callback

Subsystems: 802.11 (including cfg80211/nl80211), the rest

STALE2004d

2 messages, 1 author, 2021-02-06 · open the first message on its own page

[PATCH net-next] cfg80211: remove unused callback

From: Matteo Croce <hidden>
Date: 2021-02-06 12:30:39

From: Matteo Croce <redacted>

The ieee80211 class registers a callback which actually does nothing.
Given that the callback is optional, and all its accesses are protected
by a NULL check, remove it entirely.

Signed-off-by: Matteo Croce <redacted>
---
 net/wireless/sysfs.c | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 3ac1f48195d2..41cb4d565149 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -81,12 +81,6 @@ static void wiphy_dev_release(struct device *dev)
 	cfg80211_dev_free(rdev);
 }
 
-static int wiphy_uevent(struct device *dev, struct kobj_uevent_env *env)
-{
-	/* TODO, we probably need stuff here */
-	return 0;
-}
-
 #ifdef CONFIG_PM_SLEEP
 static void cfg80211_leave_all(struct cfg80211_registered_device *rdev)
 {
@@ -157,7 +151,6 @@ struct class ieee80211_class = {
 	.owner = THIS_MODULE,
 	.dev_release = wiphy_dev_release,
 	.dev_groups = ieee80211_groups,
-	.dev_uevent = wiphy_uevent,
 	.pm = WIPHY_PM_OPS,
 	.ns_type = &net_ns_type_operations,
 	.namespace = wiphy_namespace,
-- 
2.29.2

Re: [PATCH net-next] cfg80211: remove unused callback

From: Matteo Croce <hidden>
Date: 2021-02-06 19:48:16

On Sat, Feb 6, 2021 at 1:29 PM Matteo Croce [off-list ref] wrote:
From: Matteo Croce <redacted>

The ieee80211 class registers a callback which actually does nothing.
Given that the callback is optional, and all its accesses are protected
by a NULL check, remove it entirely.

Signed-off-by: Matteo Croce <redacted>
---
I just noticed that I forgot to cc linux-wireless, I will resend it

-- 
per aspera ad upstream
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help