[PATCH net-next] net: core: Remove extra spaces

Subsystems: networking [general], the rest

STALE2011d

3 messages, 2 authors, 2021-02-05 · open the first message on its own page

[PATCH net-next] net: core: Remove extra spaces

From: Zheng Yongjun <hidden>
Date: 2021-02-04 03:07:00

Do codingstyle clean up to remove extra spaces.

Signed-off-by: Zheng Yongjun <redacted>
---
 net/core/neighbour.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 9500d28a43b0..72ea94ec8c4a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
 
 	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
 	if (p) {
-		p->tbl		  = tbl;
+		p->tbl = tbl;
 		refcount_set(&p->refcnt, 1);
 		p->reachable_time =
 				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
-- 
2.22.0

Re: [PATCH net-next] net: core: Remove extra spaces

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-05 03:05:22

On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
quoted hunk
Do codingstyle clean up to remove extra spaces.

Signed-off-by: Zheng Yongjun <redacted>
---
 net/core/neighbour.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 9500d28a43b0..72ea94ec8c4a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
 
 	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
 	if (p) {
-		p->tbl		  = tbl;
+		p->tbl = tbl;
 		refcount_set(&p->refcnt, 1);
 		p->reachable_time =
                                  ^

It's aligned with the assignment to reachable_time.

I don't find this particularly offensive, there are worse style issues
in this function.
 				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));

答复: [PATCH net-next] net: core: Remove extra spaces

From: zhengyongjun <hidden>
Date: 2021-02-05 03:14:53

Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :)

-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@kernel.org] 
发送时间: 2021年2月5日 11:05
收件人: zhengyongjun [off-list ref]
抄送: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH net-next] net: core: Remove extra spaces

On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
quoted hunk
Do codingstyle clean up to remove extra spaces.

Signed-off-by: Zheng Yongjun <redacted>
---
 net/core/neighbour.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 
9500d28a43b0..72ea94ec8c4a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct 
net_device *dev,
 
 	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
 	if (p) {
-		p->tbl		  = tbl;
+		p->tbl = tbl;
 		refcount_set(&p->refcnt, 1);
 		p->reachable_time =
                                  ^

It's aligned with the assignment to reachable_time.

I don't find this particularly offensive, there are worse style issues in this function.
 				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help