Re: [PATCH] wireless: fix typo issue

3 messages, 3 authors, 2021-02-03 · open the first message on its own page

Re: [PATCH] wireless: fix typo issue

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-02-03 07:34:56

On Wed, 2021-02-03 at 15:00 +0800, samirweng1979 wrote:
quoted hunk
From: wengjianfeng <redacted>

change 'iff' to 'if'.

Signed-off-by: wengjianfeng <redacted>
---
 net/wireless/chan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index 285b807..2f17edf 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -1084,7 +1084,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
  * associated to an AP on the same channel or on the same UNII band
  * (assuming that the AP is an authorized master).
  * In addition allow operation on a channel on which indoor operation is
- * allowed, iff we are currently operating in an indoor environment.
+ * allowed, if we are currently operating in an indoor environment.
  */
I suspect that was intentional, as a common abbreviation for "if and
only if".

johannes

Re: [PATCH] wireless: fix typo issue

From: Miaohe Lin <linmiaohe@huawei.com>
Date: 2021-02-03 07:52:57

On 2021/2/3 15:33, Johannes Berg wrote:
On Wed, 2021-02-03 at 15:00 +0800, samirweng1979 wrote:
quoted
From: wengjianfeng <redacted>

change 'iff' to 'if'.

Signed-off-by: wengjianfeng <redacted>
---
 net/wireless/chan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index 285b807..2f17edf 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -1084,7 +1084,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
  * associated to an AP on the same channel or on the same UNII band
  * (assuming that the AP is an authorized master).
  * In addition allow operation on a channel on which indoor operation is
- * allowed, iff we are currently operating in an indoor environment.
+ * allowed, if we are currently operating in an indoor environment.
  */
I suspect that was intentional, as a common abbreviation for "if and
only if".
Yep. iff --> if and only if from:
https://mathvault.ca/math-glossary/#iff
johannes

.

Re: [PATCH] wireless: fix typo issue

From: wengjianfeng <hidden>
Date: 2021-02-03 08:14:37

On Wed, 3 Feb 2021 15:51:36 +0800
Miaohe Lin [off-list ref] wrote:
On 2021/2/3 15:33, Johannes Berg wrote:
quoted
On Wed, 2021-02-03 at 15:00 +0800, samirweng1979 wrote:
quoted
From: wengjianfeng <redacted>

change 'iff' to 'if'.

Signed-off-by: wengjianfeng <redacted>
---
 net/wireless/chan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index 285b807..2f17edf 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -1084,7 +1084,7 @@ bool cfg80211_chandef_usable(struct wiphy
*wiphy,
  * associated to an AP on the same channel or on the same UNII
band
  * (assuming that the AP is an authorized master).
  * In addition allow operation on a channel on which indoor
operation is
- * allowed, iff we are currently operating in an indoor
environment.
+ * allowed, if we are currently operating in an indoor
environment. */
I suspect that was intentional, as a common abbreviation for "if and
only if".
Yep. iff --> if and only if from:
https://mathvault.ca/math-glossary/#iff
quoted
johannes

.
Hi Johannes and Miaohe
  You are right, I make a mistake, please ignore this patch, thanks.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help