# Re: \[PATCH wpan 3/4\] net: ieee802154: fix nl802154 add llsec key

- From: Stefan Schmidt \<stefan@datenfreihafen.org\>
- Date: 2021-02-24 15:20:05 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/02/11197328
- Thread: https://ratatoskr.run/netdev/2021/02/11197141/t.md

```text
Hello.

On 21.02.21 18:43, Alexander Aring wrote:
> This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is
> not set by the user. If this is the case nl802154 will return -EINVAL.
>
> Reported-by: <redacted>
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>   net/ieee802154/nl802154.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> index 063b12cba71f..3f6d86d63923 100644
> --- a/net/ieee802154/nl802154.c
> +++ b/net/ieee802154/nl802154.c
> @@ -1544,7 +1544,8 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info)
>   	struct ieee802154_llsec_key_id id = { };
>   	u32 commands[NL802154_CMD_FRAME_NR_IDS / 32] = { };
>   
> -	if (nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack))
> +	if (!info->attrs[NL802154_ATTR_SEC_KEY] ||
> +	    nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack))
>   		return -EINVAL;
>   
>   	if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
>

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt
```
