[PATCH] fix coding style in driver/staging/qlge/qlge_main.c

Subsystems: staging subsystem, the rest

STALE2010d

2 messages, 2 authors, 2021-02-16 · open the first message on its own page

[PATCH] fix coding style in driver/staging/qlge/qlge_main.c

From: Du Cheng <hidden>
Date: 2021-02-16 07:19:38 

align * in block comments on each line

Signed-off-by: Du Cheng <redacted>
---
 drivers/staging/qlge/qlge_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 5516be3af898..bfd7217f3953 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3816,7 +3816,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
 	qlge_tx_ring_clean(qdev);
 
 	/* Call netif_napi_del() from common point.
-	*/
+	 */
 	for (i = 0; i < qdev->rss_ring_count; i++)
 		netif_napi_del(&qdev->rx_ring[i].napi);
 
-- 
2.27.0

Re: [PATCH] fix coding style in driver/staging/qlge/qlge_main.c

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-02-16 07:27:37 

On Tue, Feb 16, 2021 at 03:18:49PM +0800, Du Cheng wrote:
quoted hunk
align * in block comments on each line

Signed-off-by: Du Cheng <redacted>
---
 drivers/staging/qlge/qlge_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 5516be3af898..bfd7217f3953 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3816,7 +3816,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
 	qlge_tx_ring_clean(qdev);
 
 	/* Call netif_napi_del() from common point.
-	*/
+	 */
Just put it on the previous line please.

Also use scripts/get_maintainer.pl to find the proper lists to send this
to in the future, you forgot the staging mailing list :(

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help