[PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery

Subsystems: 8169 10/100/1000 gigabit ethernet driver, networking drivers, the rest

STALE1998d REVIEWED: 6 (6M)

1 review trailer.

2 messages, 2 authors, 2021-02-15 · open the first message on its own page

[PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-02-14 16:39:30

Armin reported that after referenced commit his RTL8105e is dead when
resuming from suspend and machine runs on battery. This patch has been
confirmed to fix the issue.

Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip versions")
Reported-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
- This fix applies on net-next. For net I submitted a separate patch.
---
 drivers/net/ethernet/realtek/r8169_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 04231585e..376dfd011 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1252,6 +1252,7 @@ static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable)
 {
 	switch (tp->mac_version) {
 	case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26:
+	case RTL_GIGA_MAC_VER_29 ... RTL_GIGA_MAC_VER_30:
 	case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_37:
 	case RTL_GIGA_MAC_VER_39 ... RTL_GIGA_MAC_VER_63:
 		if (enable)
-- 
2.30.1

Re: [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-02-15 20:41:12

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 14 Feb 2021 17:38:30 +0100 you wrote:
Armin reported that after referenced commit his RTL8105e is dead when
resuming from suspend and machine runs on battery. This patch has been
confirmed to fix the issue.

Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip versions")
Reported-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

[...]
Here is the summary with links:
  - [net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery
    https://git.kernel.org/netdev/net-next/c/d2a04370817f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help