# Re: \[PATCH net-next v2 2/2\] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

- From: Russell King - ARM Linux admin \<linux@armlinux.org.uk\>
- Date: 2021-02-13 10:46:44 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/02/11196712
- Thread: https://ratatoskr.run/netdev/2021/02/11196696/t.md

```text
On Fri, Feb 12, 2021 at 08:18:40PM -0600, Robert Hancock wrote:
> +	if (!phydev->sfp_bus &&
> +	    (!phydev->attached_dev || !phydev->attached_dev->sfp_bus)) {

First, do we want this to be repeated in every driver?

Second, are you sure this is the correct condition to be using for
this?  phydev->sfp_bus is non-NULL when _this_ PHY has a SFP bus
connected to its fibre side, it will never be set for a PHY on a
SFP. The fact that it is non-NULL or NULL shouldn't have a bearing
on whether we configure the LED register.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
```